This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Added an optional memo input #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as you can see the 'Semantic Pull Request' check is failing. Perhaps you could squash the commits into 1 and force push conforming to https://www.conventionalcommits.org/en/v1.0.0/. |
|
The git commits got squashed and it's passing all checks now. 👍 |
Co-authored-by: nicolasburtey <[email protected]>
|
@daviroo @UncleSamtoshi @jamespierog I guess we can close this PR since we already have this feature in the cash register |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Galoy backend API already supports an optional memo field when creating a lightning invoice, but the frontend interface didn't yet have a memo field. This pull request adds an optional memo field and allows users to send memos to each other over lightning invoices.
How it works
The new memo input field lives on the [username] page and passes the memo data to the ReceiveAmount and RecieveNoAmount components. The RecieveNoAmount component passes that memo information to a modified gql mutation which receives a lightning payment request from the backend. The RecieveAmount component passes the memo information to the GenerateInvoice component which generates a lightning invoice containing that memo information.
The memo input has been tested with US-ASCII characters, Korean characters, Chinese characters, and emojis, and has been able to encode memo data into lightning invoices.